Add a suffix property to LinkCompletionTools.ParsedDisambiguation
#1151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
I decided to land the bug fix separately so that it can be cherry-picked into the 6.1 release as well. I'll mark this a draft until #1152 is merged. |
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug/issue #, if applicable:
Summary
This adds a
suffixString property toLinkCompletionTools.ParsedDisambiguation.Originally I had thought that this wouldn't be necessary and that the caller could get the disambiguation suffix substring from the original link string (by dropping the
name) but the caller doesn't know the ranges of each individual path component substring and would need to re-implement their own parsing.Dependencies
None.
Testing
Call the new API. It should behave like the examples in the added tests.
Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
./bin/testscript and it succeeded