Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to set frame for returned waveform #41

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cdcapano
Copy link

This adds a frame keyword option to PrecessingSurrogate.__call__ and corresponding argument to SurrogateEvaluator.__call__. The frame argument allows the user to specify which frame to return the waveform in, inertial, co-precessing, or co-orbital. The default is inertial. I added this mostly because I want to be able to see what the underlying modes are doing in precessing signals, before they are twisted up.

I've tested this with NRSur7dq4 and it seems to work. Other classes besides PrecessingSurrogate may need to be modified before this can be merged. Since SurrogateEvaluator.__call__ will now try to pass a frame argument to _sur_dimless, any class that could be called here will also need to be able to consume a frame argument. I don't know what other classes that might be. (Aside: abstract base classes would be useful here.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant