gemspec bundler version removed #72
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shekharrajak
commented
Mar 14, 2019
| @@ -70,7 +70,7 @@ script: | |||
| - if [[ "${RUBOCOP}" == "yes" ]]; then rubocop; fi | |||
|
|
|||
| # Test ruby gem | |||
| - gem install gem-path --no-ri --no-rdoc | |||
| - gem install gem-path --no-document | |||
There was a problem hiding this comment.
In latest version of Ruby (> 2.2) , we need to use --no-document, because --no-ri --no-rdoc is deprecated.
Shekharrajak
commented
Mar 14, 2019
| @@ -12,7 +12,7 @@ Gem::Specification.new do |gem| | |||
| gem.extensions = ['ext/symengine/extconf.rb'] | |||
| gem.license = 'MIT' | |||
|
|
|||
| gem.add_development_dependency 'bundler', '~> 1.7' | |||
| gem.add_development_dependency 'bundler' | |||
There was a problem hiding this comment.
Old version doesn't support the latest Ruby versions.
|
Ping @isuruf |
Shekharrajak
force-pushed
the
shekhar_dev
branch
from
2ded9ad to
f2baf3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #71