chore(expo) : Update to Expo 50 #795
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,11 @@ | ||
| /** @type {import("@babel/core").ConfigFunction} */ | ||
| module.exports = function (api) { | ||
| api.cache(true); | ||
| return { | ||
| presets: [ | ||
| ["babel-preset-expo", { jsxImportSource: "nativewind" }], | ||
| "nativewind/babel", | ||
| ], | ||
| plugins: ["react-native-reanimated/plugin"], | ||
| }; | ||
| }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,29 +1,55 @@ | ||
| // Learn more: https://docs.expo.dev/guides/monorepos/ | ||
| const { getDefaultConfig } = require("expo/metro-config"); | ||
| const { FileStore } = require("metro-cache"); | ||
| const { withNativeWind } = require("nativewind/metro"); | ||
|
|
||
| const path = require("path"); | ||
|
|
||
| module.exports = withTurborepoManagedCache( | ||
| withMonorepoPaths( | ||
| withNativeWind(getDefaultConfig(__dirname), { | ||
| input: "./src/styles.css", | ||
| configPath: "./tailwind.config.ts", | ||
| }), | ||
| ), | ||
| ); | ||
|
|
||
| /** | ||
| * Add the monorepo paths to the Metro config. | ||
| * This allows Metro to resolve modules from the monorepo. | ||
| * | ||
| * @see https://docs.expo.dev/guides/monorepos/#modify-the-metro-config | ||
| * @param {import('expo/metro-config').MetroConfig} config | ||
| * @returns {import('expo/metro-config').MetroConfig} | ||
| */ | ||
| function withMonorepoPaths(config) { | ||
| const projectRoot = __dirname; | ||
| const workspaceRoot = path.resolve(projectRoot, "../.."); | ||
|
|
||
| // #1 - Watch all files in the monorepo | ||
| config.watchFolders = [workspaceRoot]; | ||
|
|
||
| // #2 - Resolve modules within the project's `node_modules` first, then all monorepo modules | ||
| config.resolver.nodeModulesPaths = [ | ||
| path.resolve(projectRoot, "node_modules"), | ||
| path.resolve(workspaceRoot, "node_modules"), | ||
| ]; | ||
|
|
||
| return config; | ||
| } | ||
|
|
||
| /** | ||
| * Move the Metro cache to the `node_modules/.cache/metro` folder. | ||
| * This repository configured Turborepo to use this cache location as well. | ||
| * If you have any environment variables, you can configure Turborepo to invalidate it when needed. | ||
| * | ||
| * @see https://turbo.build/repo/docs/reference/configuration#env | ||
| * @param {import('expo/metro-config').MetroConfig} config | ||
| * @returns {import('expo/metro-config').MetroConfig} | ||
| */ | ||
| function withTurborepoManagedCache(config) { | ||
| config.cacheStores = [ | ||
| new FileStore({ root: path.join(__dirname, "node_modules/.cache/metro") }), | ||
| ]; | ||
| return config; | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we nuke this file all together now? I think strict-peer-dependencies was also set for expo reasons
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can on the native side! We've been working hard to get rid of all implicit dependency references in both
/androidand/iosfolders.That means things like
expo run android|iosare working as intended, withoutnode-linker=hoisted.Unfortunately, there are a few left-over issues, e.g.
eas updatewon't work properly with this yet. Working hard to resolve them before SDK 50 stable is released.