Make --hide-instantiations default

README.md

@@ -133,8 +133,8 @@ OPTIONS:
         --ignore-filename-regex <PATTERN>
             Skip source code files with file paths that match the given regular expression
 
-        --hide-instantiations
-            Hide instantiations from report
+        --show-instantiations
+            Show instantiations in report
 
         --no-cfg-coverage
             Unset cfg(coverage), which is enabled when code is built using cargo-llvm-cov

docs/cargo-llvm-cov-report.txt

@@ -83,8 +83,8 @@ OPTIONS:
         --ignore-filename-regex <PATTERN>
             Skip source code files with file paths that match the given regular expression
 
-        --hide-instantiations
-            Hide instantiations from report
+        --show-instantiations
+            Show instantiations in report
 
         --fail-under-functions <MIN>
             Exit with a status of 1 if the total function coverage is less than MIN percent

docs/cargo-llvm-cov-run.txt

@@ -87,8 +87,8 @@ OPTIONS:
         --ignore-filename-regex <PATTERN>
             Skip source code files with file paths that match the given regular expression
 
-        --hide-instantiations
-            Hide instantiations from report
+        --show-instantiations
+            Show instantiations in report
 
         --no-cfg-coverage
             Unset cfg(coverage), which is enabled when code is built using cargo-llvm-cov

docs/cargo-llvm-cov-test.txt

@@ -92,8 +92,8 @@ OPTIONS:
         --ignore-filename-regex <PATTERN>
             Skip source code files with file paths that match the given regular expression
 
-        --hide-instantiations
-            Hide instantiations from report
+        --show-instantiations
+            Show instantiations in report
 
         --no-cfg-coverage
             Unset cfg(coverage), which is enabled when code is built using cargo-llvm-cov

docs/cargo-llvm-cov.txt

@@ -87,8 +87,8 @@ OPTIONS:
         --ignore-filename-regex <PATTERN>
             Skip source code files with file paths that match the given regular expression
 
-        --hide-instantiations
-            Hide instantiations from report
+        --show-instantiations
+            Show instantiations in report
 
         --no-cfg-coverage
             Unset cfg(coverage), which is enabled when code is built using cargo-llvm-cov

src/cli.rs

@@ -222,7 +222,7 @@ impl Args {
         let mut failure_mode = None;
         let mut ignore_filename_regex = None;
         let mut disable_default_ignore_filename_regex = false;
-        let mut hide_instantiations = false;
+        let mut show_instantiations = false;
         let mut no_cfg_coverage = false;
         let mut no_cfg_coverage_nightly = false;
         let mut no_report = false;
@@ -396,7 +396,12 @@ impl Args {
                 Long("disable-default-ignore-filename-regex") => {
                     parse_flag!(disable_default_ignore_filename_regex);
                 }
-                Long("hide-instantiations") => parse_flag!(hide_instantiations),
+                Long("show-instantiations") => parse_flag!(show_instantiations),
+                Long("hide-instantiations") => {
+                    // The following warning is a hint, so it should not be promoted to an error.
+                    let _guard = term::warn::ignore();
+                    warn!("--hide-instantiations is now enabled by default");
+                }
                 Long("no-cfg-coverage") => parse_flag!(no_cfg_coverage),
                 Long("no-cfg-coverage-nightly") => parse_flag!(no_cfg_coverage_nightly),
                 Long("no-report") => parse_flag!(no_report),
@@ -816,7 +821,7 @@ impl Args {
                 failure_mode,
                 ignore_filename_regex,
                 disable_default_ignore_filename_regex,
-                hide_instantiations,
+                show_instantiations,
                 no_cfg_coverage,
                 no_cfg_coverage_nightly,
                 no_report,
@@ -1023,8 +1028,8 @@ pub(crate) struct LlvmCovOptions {
     pub(crate) ignore_filename_regex: Option<String>,
     // For debugging (unstable)
     pub(crate) disable_default_ignore_filename_regex: bool,
-    /// Hide instantiations from report
-    pub(crate) hide_instantiations: bool,
+    /// Show instantiations in report
+    pub(crate) show_instantiations: bool,
     /// Unset cfg(coverage), which is enabled when code is built using cargo-llvm-cov.
     pub(crate) no_cfg_coverage: bool,
     /// Unset cfg(coverage_nightly), which is enabled when code is built using cargo-llvm-cov and nightly compiler.

src/main.rs

@@ -921,7 +921,7 @@ impl Format {
         match self {
             Self::Text | Self::Html => {
                 cmd.args([
-                    &format!("-show-instantiations={}", !cx.args.cov.hide_instantiations),
+                    &format!("-show-instantiations={}", cx.args.cov.show_instantiations),
                     "-show-line-counts-or-regions",
                     "-show-expansions",
                     "-show-branches=count",
@@ -1076,7 +1076,7 @@ impl Format {
 }
 
 fn ignore_filename_regex(cx: &Context) -> Option<String> {
-    // On windows, we should escape the separator.
+    // On Windows, we should escape the separator.
     const SEPARATOR: &str = if cfg!(windows) { "\\\\" } else { "/" };
 
     #[derive(Default)]

tests/test.rs

@@ -18,8 +18,8 @@ const SUBCOMMANDS: &[&str] = &["", "run", "report", "clean", "show-env", "nextes
 
 fn test_set() -> Vec<(&'static str, &'static [&'static str])> {
     vec![
-        ("txt", &["--text"]),
-        ("hide-instantiations.txt", &["--text", "--hide-instantiations"]),
+        ("txt", &["--text", "--show-instantiations"]),
+        ("hide-instantiations.txt", &["--text"]),
         ("summary.txt", &[]),
         ("json", &["--json", "--summary-only"]),
         // TODO: full JSON output is unstable between platform.