-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use extract-to if using --archive-file with nextest #266
Conversation
Oh so these profraw files are created during compilation? Then I guess I need to wrap around this command as well
Currently I think you are defaulting to |
Update: So unfortunately, the archive nextest creates do not include the profraw files or the |
This comment was marked as outdated.
This comment was marked as outdated.
Ok, the following patch should fix the failure. diff --git a/src/main.rs b/src/main.rs
index c45191b..de0284d 100644
--- a/src/main.rs
+++ b/src/main.rs
@@ -648,6 +648,11 @@ fn walk_target_dir<'a>(
// This is not the ideal way, but the way unstable book says it is cannot support them.
// https://doc.rust-lang.org/nightly/rustc/instrument-coverage.html#tips-for-listing-the-binaries-automatically
let mut target_dir = cx.ws.target_dir.clone();
+ if cx.args.subcommand == Subcommand::Nextest
+ && cx.args.cargo_args.iter().any(|a| a == "--archive-file")
+ {
+ target_dir.push("target");
+ }
// https://doc.rust-lang.org/nightly/cargo/guide/build-cache.html
if let Some(target) = &cx.args.target {
target_dir.push(target); |
What is the status of this? As far as I know, if you apply my patch, this should be mergeable, but is there any other problem? |
Let me try that patch. I think the problem was that nextest still was not really happy with the structure, but I forgot I have to check again, sorry |
Addresses #265
Fails with
That file rust-workspace-profraw-list is 0 bytes.
Not sure what is going on, maybe you can hint me what to check.
Closes: #265