Bugfix for issue #323

[jsilvabeyer]

📝 Description

Type: 🪲 bugfix

Fixes issue #323

In TARDISAtomData.create_collisions(), dropped all rows of the output DataFrame that had nan values for level_number_upper and level_number_lower, then turned all values of the atomic_number, ion_number, level_number_upper and level_number_lower columns from float64 into int.

🚦 Testing

How did you test these changes?

• Testing pipeline
• Other method (describe)
• My changes can't be tested (explain why)

☑️ Checklist

• I requested two reviewers for this pull request
• I updated the documentation according to my changes
• I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

[codecov]

Codecov Report

Merging #324 (b6172b7) into master (275c383) will decrease coverage by 1.39%.
The diff coverage is 61.85%.

@@            Coverage Diff             @@
##           master     #324      +/-   ##
==========================================
- Coverage   74.44%   73.05%   -1.40%     
==========================================
  Files          23       24       +1     
  Lines        2614     3158     +544     
==========================================
+ Hits         1946     2307     +361     
- Misses        668      851     +183     

Impacted Files	Coverage Δ
carsus/io/chianti_/chianti_.py	85.80% <0.00%> (+19.36%)	⬆️
carsus/io/output/base.py	8.98% <7.47%> (-1.86%)	⬇️
carsus/io/atom_data_compare.py	12.97% <12.97%> (ø)
carsus/io/zeta.py	27.65% <16.66%> (-2.35%)	⬇️
carsus/io/cmfgen/base.py	87.14% <85.49%> (+3.14%)	⬆️
carsus/io/cmfgen/util.py	94.11% <94.11%> (ø)
carsus/io/kurucz/gfall.py	95.11% <100.00%> (-0.13%)	⬇️
carsus/io/nist/ionization.py	97.63% <100.00%> (+1.10%)	⬆️
carsus/io/nist/weightscomp.py	99.01% <100.00%> (+1.84%)	⬆️
carsus/io/util.py	100.00% <100.00%> (ø)
... and 3 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[epassaro]

I need to take a closer look at this, this is related to #308

[afloers]

what's the status of this PR? @epassaro @jsilvabeyer

[afloers]

closed for now, if somebody wants to continue working on it please do so