fix: MM remote improvements #519
Conversation
The scheduler would never trigger, because the MM remote never populated the list of rooms the bot can talk in. The bot should now support the output_rooms option in rules.
Helps simplify the code to call the function once instead of running through all the steps to create a direct message every time.
JamesMConroy
requested review from
delta592,
wass3rw3rk,
sjqnn and
JordanSussman
as code owners
|
thanks for the PR, i'll review over the next few days! |
|
Thank you, Only thing is that I couldn't run the lint target. golangci-lint would freeze and use all my cpu. |
|
Oh, yikes. That's new. I'll see if I encounter that as well. Thanks for the heads up. |
Pull Request Test Coverage Report for Build 11300483375Details
💛 - Coveralls |
|
the linter ran, if you want to fix up the issues from that. seems like mostly minor style issues. i will run some tests on mattermost in the meantime. i did run golangci-lint locally ( thanks again for the contribution. |
stuff like cuddled assignements, unnessisary new lines, and putting the context argument first in function parameters
I must of annoyed the computer goblins or something. Here's what it looks like using the example scheduler rule
Changes are pushed. I'll probably make another MR when I want to add reactions. |
|
oh the channels are specified with |
Proposed change
Update the MM remote so it supports
Types of changes
What types of changes is this pull request introducing to flottbot?
Checklist
You can fill this out after creating your PR. Put an
xin the boxes that apply