Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added docs & tests for options.preload #11

Merged
merged 3 commits into from
Aug 22, 2016
Merged

Added docs & tests for options.preload #11

merged 3 commits into from
Aug 22, 2016

Conversation

hzlmn
Copy link
Contributor

@hzlmn hzlmn commented Aug 22, 2016

Related to #10.
Added docs (text should be discussed) and test cases (maybe more?).
@lukeed

t.end()
})

test('fly-babel preloading should pass on unfound plugins/presets', function (t) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about "preloading does nothing if plugins/presets not found" ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not strong in naming, so looks good 👍

@lukeed
Copy link
Contributor

lukeed commented Aug 22, 2016

Thank you sir 👍

Resolves #10.

@lukeed lukeed merged commit e16db02 into taskrjs:master Aug 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants