Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tests for plugins preloading, make only one loop over deps #12

Merged
merged 2 commits into from
Aug 25, 2016
Merged

Added tests for plugins preloading, make only one loop over deps #12

merged 2 commits into from
Aug 25, 2016

Conversation

hzlmn
Copy link
Contributor

@hzlmn hzlmn commented Aug 25, 2016

Added plugins preloading test. Also current solution iterates with reduce two times over the same collection.

@@ -29,6 +29,7 @@
"source-map": "^0.4.4"
},
"devDependencies": {
"babel-plugin-transform-function-bind": "^6.8.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't need this here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need because transforming will fail in test.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, right. Durr... There has to be a better way for that though. Doesn't really matter though. /future

@lukeed lukeed merged commit 9c52ccf into taskrjs:master Aug 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants