Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Babel 6 #3

Merged
1 commit merged into from
Dec 19, 2015
Merged

Babel 6 #3

1 commit merged into from
Dec 19, 2015

Conversation

lukeed
Copy link
Contributor

@lukeed lukeed commented Dec 18, 2015

Upgrade to v6.
Include es2015 preset by default (99% of the reason why people choose babel anyway)

Solves #120

return this.filter("babel", (data, options) => {
return assign({ ext: ".js"}, babel(data.toString(), options))
return this.filter('babel', (data, options) => {
return assign({ ext: '.js'}, babel(data.toString(), options))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pet peeve: Nothing against single quotes, but I don't see this change really necessary. Do you mind reverting to double quotes?

@lukeed
Copy link
Contributor Author

lukeed commented Dec 18, 2015

@bucaran lol, double quotes are my petpeeve 😉

ghost pushed a commit that referenced this pull request Dec 19, 2015
@ghost ghost merged commit 68cf7ec into taskrjs:master Dec 19, 2015
@ghost
Copy link

ghost commented Dec 19, 2015

@lukeed Thanks!

@lukeed lukeed mentioned this pull request Jan 7, 2016
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant