Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add running test with miri to CI #842

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Add running test with miri to CI #842

merged 1 commit into from
Nov 13, 2023

Conversation

pcwizz
Copy link
Contributor

@pcwizz pcwizz commented Nov 10, 2023

For T1 Rust targets Miri is able to check for several forms of undefined behavior that rustc can not.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Checklist

  • This PR will resolve #___
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary
  • It can be built on all targets and pass CI/CD.

Other information

@wusyong
Copy link
Member

wusyong commented Nov 12, 2023

@pcwizz You need to sign the commit in order to let the PR get merged.

For T1 Rust targets Miri is able to check for several forms of undefined
behavior that rustc can not.
@pcwizz
Copy link
Contributor Author

pcwizz commented Nov 12, 2023

@pcwizz You need to sign the commit in order to let the PR get merged.

Awesome that you are enforcing commit signing.

@wusyong wusyong merged commit 5c22d76 into tauri-apps:dev Nov 13, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants