feat: show safe mode alert when tapping status bar #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
@iCrazeiOS can we make this show an indicator in the status bar? Like how substrate itself does. Once that change is made I can merge this in, looks good otherwise. |
|
How do you think that should look? Substrate's was only designed for non-notched devices Can't really fit much text up there anymore without making it look weird |
|
Maybe some kind of alert icon then? Just something to indicate that it's actually tappable and can do something. |
|
Can something like the blue location pill be added, just make it red? If you use the right objc methods it’ll work on all devices |
|
|
|
Tested on a notched device (11 Pro) and non-notched (6S). CI Test has failed, but that's because of some Procursus issue, not due to this commit 🙃 |
dhinakg
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
discussed in #43