Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 71 - remove min from payment cycle calculation #84

Draft
wants to merge 1 commit into
base: merge-train-r5
Choose a base branch
from
Draft

Issue 71 - remove min from payment cycle calculation #84

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions packages/contracts/contracts/libraries/V2Calculations.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,8 +127,11 @@ library V2Calculations {
// NOTE: the last cycle could have less than the calculated payment amount

//the amount owed for the cycle should never exceed the current payment cycle amount so we use min here
uint256 owedAmountForCycle = Math.min( ((_bid.terms.paymentCycleAmount * owedTime) ) /
_paymentCycleDuration , _bid.terms.paymentCycleAmount+interest_ ) ;
//uint256 owedAmountForCycle = Math.min( ((_bid.terms.paymentCycleAmount * owedTime) ) /
// _paymentCycleDuration , _bid.terms.paymentCycleAmount+interest_ ) ;

uint256 owedAmountForCycle = ((_bid.terms.paymentCycleAmount * owedTime) ) /
_paymentCycleDuration ;

uint256 owedAmount = isLastPaymentCycle
? owedPrincipal_ + interest_
Expand Down
Loading