Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/sherlock/187 alt #100

Draft
wants to merge 3 commits into
base: fix/sherlock/205
Choose a base branch
from
Draft

Fix/sherlock/187 alt #100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7b9653b
adding deadline
ethereumdegen May 11, 2023
130c223
merge
ethereumdegen May 11, 2023
585f48f
merge
ethereumdegen May 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/contracts/contracts/TellerV2.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,12 +354,14 @@ contract TellerV2 is
uint256 _principal,
uint32 _duration,
uint16 _APR,
uint32 deadline,
string calldata _metadataURI,
address _receiver,
Collateral[] calldata _collateralInfo,
ExpectedMarketParams calldata _expectedMarketParams
) public override whenNotPaused returns (uint256 bidId_) {

require(block.timestamp < deadline, "Deadline not met");
(uint32 paymentCycle, PaymentCycleType paymentCycleType) = marketRegistry
.getPaymentCycle(_marketplaceId);

Expand Down
2 changes: 1 addition & 1 deletion packages/contracts/contracts/interfaces/ITellerV2.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ interface ITellerV2 {
uint256 _principal,
uint32 _duration,
uint16 _APR,

uint32 deadline,
address _receiver,
Collateral[] calldata _collateralInfo,
ExpectedMarketParams calldata _expectedMarketParams
Expand Down