Collateral Manager V2 #116
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/contracts/contracts/bundle/interfaces/ICollateralBundle.sol
Outdated
Show resolved
Hide resolved
Comment on lines
120
to
131
| IERC165(_token._collateralAddress).supportsInterface(0x80ac58cd) | ||
| returns (bool supported721) { | ||
| require(supported721, "TokenBundle: ERC721 Interface Not Supported"); | ||
| } catch { | ||
| revert("TokenBundle: ERC721 Interface Not Supported"); | ||
| } | ||
| } else if (_token._collateralType == CollateralType.ERC1155) { | ||
| try | ||
| IERC165(_token._collateralAddress).supportsInterface(0xd9b67a26) | ||
| returns (bool supported1155) { | ||
| require(supported1155, "TokenBundle: ERC1155 Interface Not Supported"); | ||
| } catch { |
There was a problem hiding this comment.
I'm worried that there are several tokens that don't implement the supportsInterface function that would cause this to fail
There was a problem hiding this comment.
This is just the way that thirdweb contract was written. So we can either choose to change it or leave it as is based on this info. i agree w you. I wonder why they did this.
There was a problem hiding this comment.
maybe we leave it for now and if we have any issues try to come up with a solution but not sure there is a good one
i.e. I wanted to figure out the token type to know which transfer function I have to call but this was the best I found
https://chat.openai.com/share/5fb9afbf-9d4b-4704-9359-145898ea906f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses thirdweb's token bundling contracts to simplify collateral management and reduce gas costs for submit bid by ~50%
Note: the thirdweb contracts variable names were changed to match the way we named them in CollateralManagerV1 but the logic has not been modified significantly.