Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sentiment140 download url 404 error #10986

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

duoan
Copy link

@duoan duoan commented Jan 23, 2025

The original URL already enabled https. https://cs.stanford.edu/people/alecmgo/trainingandtestdata.zip

Thank you for your contribution!

Please read https://www.tensorflow.org/datasets/contribute#pr_checklist to make sure your PR follows the guidelines.

Add Dataset

  • Dataset Name: sentiment140
  • Issue Reference:
  • dataset_info.json Gist:

Description

Got 404 error with the following code, since the current http url http://cs.stanford.edu/people/alecmgo/trainingandtestdata.zip will be auto redirected to https://www.cs.stanford.edu/people/alecmgo/trainingandtestdata.zip, which does not exist.

dataset, info = tfds.load(
    name="sentiment140",
    with_info=True
)

error stack

...
DownloadError: Failed to get url https://www.cs.stanford.edu/people/alecmgo/trainingandtestdata.zip. HTTP code: 404.

Checklist

  • Address all TODO's
  • Add alphabetized import to subdirectory's __init__.py
  • Run download_and_prepare successfully
  • Add checksums file
  • Properly cite in BibTeX format
  • Add passing test(s)
  • Add test data
  • If using additional dependencies (e.g. scipy), use lazy_imports (if applicable)
  • Add data generation script (if applicable)
  • Lint code

Copy link

google-cla bot commented Jan 23, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant