Add package MQTTSuite, a lightweight MQTT Integration System

[VolkerChristian]

MQTTSuite: https://github.com/SNodeC/mqttsuite

[TomJo2000]

• See related:
  Add package easyloggingpp used in coming SNode.C and MQTTSuite packages #23589
  Add package SNode.C used in coming MQTTSuite package. #23590

By the way, it is completely permissible to add a package and its dependencies in a single PR with separate commits (for future reference)

[TomJo2000]

Thank you for your contribution.
I've left you a couple suggestions.

I also can't help but notice that this seems to be a new personal project of yours.
We have a "package request checklist", an abridged version of which I'll go through below.
But tl;dr, we usually prefer packaging established packages with a history of frequent development, and existing packages.

• The project is actively developed.

• The project has existing packages and is "well known".

• Licensed under an open source license.

• Not available through a language package manager: pip, npm, cpan, cargo, etc.

• Not taking up too much disk space (< 100MiB per architecture, exceptions can be made)

• Not duplicating the functionality of existing packages.

• Not serving hacking, malware, phishing, spamming, spying, ddos functionality.

• I certify that I have read Termux Packaging Policy and understand that my request will be denied if it is found lacking.

These requirements aren't absolute.
But are what we generally take into account for adding packages to the main repository.
You may want to consider submitting this package (and its dependencies) to the TUR instead.
Which has less strict criteria for packages.

You are of course welcome to keep this PR open to work out any build issues.

[TomJo2000]

Multiple licenses should be delimited with a comma.

Suggested change

	TERMUX_PKG_LICENSE="MIT OR LGPL-3.0-or-later"
	TERMUX_PKG_LICENSE="MIT, LGPL-3.0-or-later"

For example see ipfs:

termux-packages/packages/ipfs/build.sh

Line 3 in 054de3f

TERMUX_PKG_LICENSE="MIT, Apache-2.0"

[TomJo2000]

Suggested change

TERMUX_PKG_LICENSE_FILE="LICENSE"

The license file only needs to be specified if the build system is unable to find it in the "common license files" list.

termux-packages/scripts/build/termux_step_install_license.sh

Lines 36 to 44 in 054de3f

	local COMMON_LICENSE_FILES=( # search list for licenses with copyright information
	'COPYING' 'Copyright.txt'
	'copyright' 'Copyright' 'COPYRIGHT'
	'licence' 'Licence' 'LICENCE' # spelled with 'C'
	'license' 'License' 'LICENSE' # spelled with 'S'
	'license.txt' 'License.txt'
	'LICENSE.txt' 'LICENSE.TXT'
	'license.md' 'LICENSE.md'
	)

[TomJo2000]

We usually prefer building from release tarballs.

Suggested change

	TERMUX_PKG_SRCURL="git+https://github.com/SNodeC/mqttsuite.git"
	TERMUX_PKG_SRCURL="https://github.com/SNodeC/mqttsuite/archive/refs/tags/v${TERMUX_PKG_VERSION}.tar.gz"

This also allows us to verify the release tarball via the TERMUX_PKG_SHA256 checksum.

[TomJo2000]

Dependency lists usually include a space between entries for readability,
though this isn't strictly required.

Suggested change

	TERMUX_PKG_DEPENDS="fmt,snode.c"
	TERMUX_PKG_DEPENDS="fmt, snode.c"

[TomJo2000]

Specifying TERMUX_PKG_FORCE_CMAKE is rarely necessary.

[VolkerChristian]

Thank you for the hints! I will prepare pull requests for TUR.

[TomJo2000]

Since you are a first time contributor a maintainer will need to approve your CI builds, I apologize for any delays caused by this.

You may want to consider using our build container locally for build testing.
E.g.

./scripts/run-docker.sh ./build-package.sh -I -f -a all mqttsuite

• -I instructs the build system to download dependencies from the Termux repos when possible instead of building them locally
• -f forces rebuilds of the specified packages even if they have already been built locally.
• -a all specifies that the packages should be built for all 4 architectures supported on Termux. (aarch64,arm,i686 and x86_64)