-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update runc to 1.3.0-rc.1 #23603
base: master
Are you sure you want to change the base?
update runc to 1.3.0-rc.1 #23603
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't usually update packages to -rc
releases, but I think this would be a reasonable case for an exception to that policy.
LGTM.
7c089cc
to
8902e3a
Compare
6039017
to
47e06e7
Compare
TERMUX_PKG_SRCURL=https://github.com/opencontainers/runc/archive/v${TERMUX_PKG_VERSION}.tar.gz | ||
TERMUX_PKG_SHA256=1ae11980477b789732915dfd7ba4246f5babe5ff76a31021d36365007d9713b0 | ||
TERMUX_PKG_VERSION="1.3.0~rc.1" | ||
_REAL_VERSION="${TERMUX_PKG_VERSION/\~/-}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Emmm... It is not enough just change it here. termux_pkg_auto_update
should be overriden too.
termux-packages/x11-packages/wine-devel/build.sh
Lines 86 to 107 in 14fb540
termux_pkg_auto_update() { | |
local _staging_url="https://github.com/wine-staging/wine-staging" | |
local latest_tag | |
latest_tag="$(termux_github_api_get_tag "${_staging_url}" "${TERMUX_PKG_UPDATE_TAG_TYPE}")" | |
(( ${#latest_tag} )) || { | |
printf '%s\n' \ | |
'WARN: Auto update failure!' \ | |
"latest_tag=${latest_tag}" | |
return | |
} >&2 | |
if [[ "${latest_tag}" == "${_REAL_VERSION}" ]]; then | |
echo "INFO: No update needed. Already at version '${_REAL_VERSION}'." | |
return | |
fi | |
if [ "${latest_tag/-/\~}" != "${latest_tag}" ]; then | |
latest_tag="${latest_tag/-/\~}" | |
fi | |
termux_pkg_upgrade_version "${latest_tag}" | |
} |
Internal patches could be removed. Fixes were delivered to upstream:
both are released in https://github.com/opencontainers/runc/releases/tag/v1.3.0-rc.1.
Tested on Android 14 with
4.19.318
.