Implementation of Atomic tagging #414
Conversation
|
There's not really any reason to introduce a new option. It should use in-stream tags for non-spot instance and dumb-slow-tags for spot instances. (also almost everyone should probably be using spot instances for kitchen-ec2 which is part of why I've not really bothered fixing this) |
.travis.yml
Outdated
| @@ -3,7 +3,7 @@ cache: bundler | |||
| sudo: false | |||
| branches: | |||
| only: | |||
| - master | |||
| - atomic-tags | |||
There was a problem hiding this comment.
This doesn't work, also never do this in a FOSS project.
There was a problem hiding this comment.
Absolutely, I was just running through travis for my local branch and forgot to revert it.
kitchen-ec2.gemspec
Outdated
| @@ -23,7 +23,7 @@ Gem::Specification.new do |gem| | |||
| gem.add_dependency "test-kitchen", "~> 1.4", ">= 1.4.1" | |||
| gem.add_dependency "excon" | |||
| gem.add_dependency "multi_json" | |||
| gem.add_dependency "aws-sdk", "~> 2" | |||
| gem.add_dependency "aws-sdk", "~> 3" | |||
There was a problem hiding this comment.
This needs to be x-ref'd with ChefDK.
There was a problem hiding this comment.
ChefDK is using ~> 2, I am going to change it back.
|
At our work we are using normal instances and not spot instances and also want to restrict instance creations with valid tags using IAM. I will implement in-stream tags for non spot instances. |
|
@coderanger I have updated the branch, can you please have a look? |
|
I'm looking to continue this work; @sumitag do you mind if I adopt this PR? |
|
Please feel free to use the PR |
|
This has been resolved with #496 |
Potential implementation using a flag for #360