Adds support for Rocky and AlmaLinux #602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wasn't sure on the platform name itself, so I added both |
RulerOf
reviewed
Apr 17, 2023
| module Driver | ||
| class Aws | ||
| class StandardPlatform | ||
| # https://docs.aws.amazon.com/linux/al2023/release-notes/relnotes.html |
There was a problem hiding this comment.
This comment is confusing, I assume you're duplicating the class for AL2023
RulerOf
reviewed
Apr 17, 2023
|
|
||
| def image_search | ||
| search = { | ||
| "owner-id" => "792107900819", |
There was a problem hiding this comment.
I suggest commenting with a link to the docs that establish this as the correct owner ID. I googled the number and the first result isn't what I was looking for.
There was a problem hiding this comment.
I'm not a maintainer just figured I'd point out the things I saw since I was reading the code anyway ¯\_(ツ)_/¯
tas50
reviewed
Jun 14, 2023
| module Driver | ||
| class Aws | ||
| class StandardPlatform | ||
| # https://docs.aws.amazon.com/linux/al2023/release-notes/relnotes.html |
There was a problem hiding this comment.
Suggested change
| # https://docs.aws.amazon.com/linux/al2023/release-notes/relnotes.html |
|
I'll clean up a few things in a followup PR. Thanks @jakauppila |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for Rocky and AlmaLinux
Issues Resolved
#563 #564
Check List