fix: remove DOM elements even if component creation fails #314
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes #190 by simplifying the caching strategy and ensuring the
target
div is added to the cache as soon as it's created, rather than after the component is rendered.While working on this PR, I noticed a few inconsistencies with the
render
function's API, so I filed #312 and #313Will keep this as a draft until I've smoke tested on my current app's suite
Change log
target
element to cache immediatelyrenderComponent
functioncleanupComponent
andcleanupTarget
functionsRemoveI elected to keep this for strict backwards compatibilitycomponent.$$.on_destroy
usage$$.on_destroy
was added in feat: update lib #54, which was a big rewrite about 5 years agounmount
andcleanup