docs(svelte-testing-library): update vitest and jest setup instructions #1360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testing-library ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
7 tasks
yanick
reviewed
Jan 30, 2024
Comment on lines
40
to
41
| 2. Add a `vitest-setup.js` file to configure cleanup and | ||
| [`@testing-library/jest-dom`][@testing-library/jest-dom], if using. |
There was a problem hiding this comment.
Suggested change
| 2. Add a `vitest-setup.js` file to configure cleanup and | |
| [`@testing-library/jest-dom`][@testing-library/jest-dom], if using. | |
| 2. Add a `vitest-setup.js` file to optionally set up automatic post-test cleanup and | |
| [`@testing-library/jest-dom`][@testing-library/jest-dom] expect matchers. |
yanick
reviewed
Jan 30, 2024
|
|
||
| 4.2 import `vitest-dom` at within the vitest setup file (usually | ||
| `vitest-setup.(js|ts)`) | ||
| 4. Add test scipts to your `package.json` to run the tests with Vitest |
There was a problem hiding this comment.
Suggested change
| 4. Add test scipts to your `package.json` to run the tests with Vitest | |
| 4. Add test scripts to your `package.json` to run the tests with Vitest |
yanick
suggested changes
Jan 30, 2024
timdeschryver
approved these changes
Feb 1, 2024
There was a problem hiding this comment.
LGTM 👍
@yanick can you let us know if these changes are good for you?
yanick
approved these changes
Feb 1, 2024
@timdeschryver Looks good! 👍 |
|
@all-contributors please add @mcous for docs, review |
|
I've put up a pull request to add @mcous! 🎉 |
This was referenced Feb 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Both the Vitest and Jest setup instructions for svelte-testing-library were a bit out of date. This PR updates them both.
The examples section needs updating, too, but I'll submit that as a separate PR.
Issues
cleanupis not automatically called after each test #1331