react-native-sdk: add swarm connect to ipfs api #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Li Zheng <[email protected]>
Signed-off-by: Li Zheng <[email protected]>
Signed-off-by: Li Zheng <[email protected]>
|
@asutula , since android-textile has been set to v2.0.9 and ios-textile has been set to v2.0.11 , it's possible to merge this PR 😝 |
asutula
reviewed
Oct 16, 2019
| @@ -39,6 +39,25 @@ public void run() { | |||
| }); | |||
| } | |||
|
|
|||
| @ReactMethod | |||
| public void connect(final String multiaddr, final Promise promise) { | |||
There was a problem hiding this comment.
Can we just update this to swarmConnect everywhere for consistency with the native sdks?
There was a problem hiding this comment.
I just named it for consistency with the js-http-client sdk , ref to https://github.com/textileio/js-http-client/blob/5f8b3a421ca682b3ba5ed3d4af96bca1d0913a39/src/modules/ipfs.ts#L58 ... So should we still update this to swarmConnect?
There was a problem hiding this comment.
Ah ok, that makes sense. Let's just leave this as is then.
asutula
approved these changes
Oct 17, 2019
asutula
approved these changes
Oct 17, 2019
|
Ok 3.0.13 is released! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
swarm connectto Update React Native APIs to match more closely the JS and Rest APINeed PR:
android-textile: add swarm connect to ipfs api and set android-textile to v2.0.9
ios-textile: add swarm connect to ipfs api and set ios-textile to v2.0.11