[ET-2297] Follow Up - Fixing tests #3579
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emplate for emails
…age-template-override-path-correction [ET-2296] Correct template override path for My Tickets page
…s-calendar/event-tickets into feature/add_ian_for_et
…s-calendar/event-tickets into feature/add_ian_for_et
…s-calendar/event-tickets into feature/add_ian_for_et
…m:the-events-calendar/event-tickets into fix/ET-2309-prevent-fatal-attenddee-model
* Modify pup config and GitHub zip workflow. * Organize composer.json and add code to prevent composer from timing out when running pup build commands. * Add distfiles * update-browserslist (bonus)
…vent-tickets into fix/ET-2309-prevent-fatal-attenddee-model
…m:the-events-calendar/event-tickets into fix/ET-2309-prevent-fatal-attenddee-model
Co-authored-by: Stephen Page <[email protected]>
…-fatal-attenddee-model Prevent fatal error for Attendee Models with Invalid Orders
sdokus
added
question
tec-bot
reviewed
Feb 21, 2025
| * @since TBD | ||
| */ | ||
| protected function do_register(): void { | ||
| add_filter( 'tec_tickets_commerce_prepare_order_for_email', [ $this, 'add_fees_to_emails'] , 10, 2 ); |
There was a problem hiding this comment.
[phpcs] reported by reviewdog 🐶NormalizedArrays.Arrays.ArrayBraceSpacing.SpaceBeforeArrayCloserSingleLine
Expected 1 space before the array closer in a single line array. Found: no spaces
| * @since TBD | ||
| */ | ||
| protected function do_register(): void { | ||
| add_filter( 'tec_tickets_commerce_prepare_order_for_email', [ $this, 'add_fees_to_emails'] , 10, 2 ); |
There was a problem hiding this comment.
[phpcs] reported by reviewdog 🐶Generic.Functions.FunctionCallArgumentSpacing.SpaceBeforeComma
Space found before comma in argument list
| remove_filter( 'tec_tickets_commerce_prepare_order_for_email', [ $this, 'add_fees_to_emails' ] ); | ||
| } | ||
|
|
||
| /** |
There was a problem hiding this comment.
[phpcs] reported by reviewdog 🐶Squiz.Commenting.FunctionComment.MissingParamTag
Doc comment for parameter "$original_items" missing
dpanta94
added
the
needs release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
ET-2297
🗒️ Description
In PR #3558 I introduced new tests that did not account for the passage of time which will cause snapshots to fail if not updated every day. This PR adds the use of
With_Clock_Mockto "freeze time" for the snapshot.I also removed an extra blank line from the Fee Template that was missed in the initial PR.
🎥 Artifacts
✔️ Checklist
npm run changelogto add changelog file(s). More info herewpunitorintegrationtests.wpunitorintegrationtests.