Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move QR code library to Common #2421

Open
wants to merge 3 commits into
base: bucket/qr-code
Choose a base branch
from
Open

Move QR code library to Common #2421

wants to merge 3 commits into from

Conversation

pattihis
Copy link
Contributor

@pattihis pattihis commented Mar 1, 2025 •
edited
Loading

🎫 Ticket

TEC-5403

🗒️ Description

Move the existing QR code generation library from Event Tickets into Common. Goes along with:
the-events-calendar/event-tickets#3617

✔️ Checklist

  • Ran npm run changelog to add changelog file(s). More info here
  • Code is covered by NEW wpunit or integration tests.
  • Code is covered by EXISTING wpunit or integration tests.
  • Are all the required tests passing?
  • Automated code review comments are addressed.
  • Have you added Artifacts?
  • Check the base branch for your PR.
  • Add your PR to the project board for the release.

@pattihis pattihis self-assigned this Mar 1, 2025
@pattihis pattihis requested a review from bordoni March 1, 2025 23:36
@pattihis pattihis added the needs release Needs an associated release in Central before merging. label Mar 3, 2025
Base automatically changed from release/T25.batman to master March 4, 2025 14:51
@pattihis pattihis removed the needs release Needs an associated release in Central before merging. label Mar 5, 2025
@pattihis pattihis changed the base branch from master to bucket/qr-code March 5, 2025 22:22
Camwyn
Camwyn requested changes Mar 6, 2025
View reviewed changes
Copy link
Member

@Camwyn Camwyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually - if we are including it in vendor, why not use Strauss, namespace and version-lock it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Camwyn Camwyn Camwyn requested changes

@bordoni bordoni Awaiting requested review from bordoni

Requested changes must be addressed to merge this pull request.

Assignees

@pattihis pattihis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pattihis @Camwyn