Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure host for global registration #3242

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

Lennonka
Copy link
Contributor

@Lennonka Lennonka commented Aug 26, 2024

What changes are you introducing?

A host needs to be configured a certain way before it can be registered by using Global Registration and that isn't properly documented at the present time.

We have a Configure a host for registration module, but we don't use it in the Managing Hosts guide currently, which we should. Originally, it covered only the NTP synchronization.

Also, we should provide a prerequisite so that the user can make a secured curl call right away. The CA certificate config is now also included in the pre-registration configuration.

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

Because it's better to tell the user how the host must be configured for registration beforehand instead of explaining it when it's "too late".

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

Depends on #3193

Checklists

  • I am okay with my commits getting squashed when you merge this PR.
  • I am familiar with the contributing guidelines.

Please cherry-pick my commits into:

  • Foreman 3.12/Katello 4.14 (Satellite 6.16)
  • Foreman 3.11/Katello 4.13
  • Foreman 3.10/Katello 4.12
  • Foreman 3.9/Katello 4.11 (Satellite 6.15; orcharhino 6.8/6.9/6.10)
  • Foreman 3.8/Katello 4.10
  • Foreman 3.7/Katello 4.9 (Satellite 6.14)
  • Foreman 3.6/Katello 4.8
  • Foreman 3.5/Katello 4.7 (Satellite 6.13; orcharhino 6.6/6.7)
  • We do not accept PRs for Foreman older than 3.5.

@Lennonka Lennonka force-pushed the configure-host-for-global-reg branch from 539a35f to 08035ed Compare August 26, 2024 22:04
@Lennonka

This comment was marked as outdated.

@Lennonka Lennonka force-pushed the configure-host-for-global-reg branch 2 times, most recently from 5c131b3 to f43e4fd Compare September 16, 2024 18:05
@Lennonka Lennonka marked this pull request as ready for review September 16, 2024 18:15
@Lennonka
Copy link
Contributor Author

Open to suggestions :)

@Lennonka Lennonka added Needs tech review Requires a review from the technical perspective Needs style review Requires a review from docs style/grammar perspective Not yet reviewed labels Sep 16, 2024
Copy link
Contributor

@maximiliankolb maximiliankolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some suggestions.

@Lennonka Lennonka marked this pull request as draft September 30, 2024 15:17
@Lennonka Lennonka marked this pull request as ready for review September 30, 2024 16:54
@Lennonka
Copy link
Contributor Author

I have rewritten the configuring procedure because earlier I was referring users to an incorrect certificate file.

I have also successfully tested the configuration + secure registration on RHEL 9. ✔️

Copy link
Contributor

@maximiliankolb maximiliankolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM style-wise.

@maximiliankolb maximiliankolb added style review done No issues from docs style/grammar perspective and removed Needs style review Requires a review from docs style/grammar perspective labels Oct 1, 2024
@Lennonka Lennonka added tech review done No issues from the technical perspective and removed Needs tech review Requires a review from the technical perspective labels Oct 2, 2024
@Lennonka
Copy link
Contributor Author

Lennonka commented Oct 2, 2024

I'm setting the tech review done flag because I've tested it successfully. ^^

@Lennonka Lennonka force-pushed the configure-host-for-global-reg branch from 7e95b7c to d88007e Compare October 2, 2024 17:22
@Lennonka Lennonka force-pushed the configure-host-for-global-reg branch from d88007e to 6e6ef51 Compare October 2, 2024 17:33
@Lennonka
Copy link
Contributor Author

Lennonka commented Oct 2, 2024

Rebased.

@Lennonka Lennonka merged commit 8b09e31 into theforeman:master Oct 2, 2024
9 checks passed
@Lennonka
Copy link
Contributor Author

Lennonka commented Oct 2, 2024

Cherry-picked:

There were conflicts on 3.8, therefore I'm not cherrypicking it further.

@Lennonka Lennonka deleted the configure-host-for-global-reg branch October 2, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
style review done No issues from docs style/grammar perspective tech review done No issues from the technical perspective
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants