Limit host resources via Hammer CLI #3575
Open
+125
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximiliankolb
added
Needs tech review
|
The PR preview for 6196627 is available at theforeman-foreman-documentation-preview-pr-3575.surge.sh The following output files are affected by this PR: |
maximiliankolb
commented
Jan 16, 2025
guides/common/modules/proc_assigning-resource-quotas-to-a-user.adoc
Outdated
Show resolved
Hide resolved
maximiliankolb
force-pushed
the
foreman_resource_quota_hammer_cli
branch
2 times, most recently
from
570ebdf to
b95fd30
Compare
maximiliankolb
commented
Jan 20, 2025
Lennonka
reviewed
Jan 20, 2025
| --cpu-cores _My_CPU_Cores_ \ | ||
| --disk-space _My_Disk_Space_in_GiB_ \ | ||
| --id _My_Resource_Quota_ID_ \ | ||
| --memory _My_Memory_in_MiB_ \ |
There was a problem hiding this comment.
Are you absolutely sure that the unit is MebiBytes (MiB) and not MegaBytes (MB)? Those are different units. And Mi- Gi- aren't usually used. 🤷♀️
The same for the GiB above and other places.
There was a problem hiding this comment.
@bastian-src Can you please confirm if it's MiB or MR etc?
maximiliankolb
commented
Jan 21, 2025
| --cpu-cores _My_CPU_Cores_ \ | ||
| --disk-space _My_Disk_Space_in_GiB_ \ | ||
| --id _My_Resource_Quota_ID_ \ | ||
| --memory _My_Memory_in_MiB_ \ |
There was a problem hiding this comment.
@bastian-src Can you please confirm if it's MiB or MR etc?
guides/common/modules/proc_assigning-resource-quotas-to-a-user.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/proc_assigning-resource-quotas-to-a-user-group.adoc
Outdated
Show resolved
Hide resolved
maximiliankolb
force-pushed
the
foreman_resource_quota_hammer_cli
branch
from
b95fd30 to
9141e4c
Compare
maximiliankolb
commented
Jan 22, 2025
guides/common/modules/proc_assigning-resource-quotas-to-a-user-group.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/proc_assigning-resource-quotas-to-a-user.adoc
Outdated
Show resolved
Hide resolved
* Add command to install Hammer CLI plugin for foreman_resource_quota * Use Hammer CLI to assign resource quotes to users * Use Hammer CLI to manage resource quotas Refs PR 7 in hammer-cli-foreman-resource-quota on GitHub Refs PR 97 in foreman_resource_quota on GitHub Refs https://github.com/ATIX-AG/hammer-cli-foreman-resource-quota/
maximiliankolb
force-pushed
the
foreman_resource_quota_hammer_cli
branch
from
9141e4c to
6196627
Compare
|
Applied suggestion by Anet; rebased to "master", tested all commands again on Foreman/Katello. Needs final tech ACK on the units. cc @bastian-src |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are you introducing?
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
Checklists
no cherry-picks: only foreman_resource_quota is part of 3.13; the Hammer CLI plugin is not available in nightly.