Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add invalidating registration tokens #3595

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

Lennonka
Copy link
Contributor

@Lennonka Lennonka commented Jan 17, 2025

What changes are you introducing?

Adding 3 procedures for invalidation of the registration JSON Web Tokens (JWTs):

  1. Invalidating one's own JWTs
  2. Invalidating JWTs of one or more other users
  3. Invalidating JWTs of all users at once

All three user stories will be available in the UI, CLI, and API.

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

Redmine: 37936, 38138, 38124
RH Jira: SAT-27385 (private)

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

Checklists

  • I am okay with my commits getting squashed when you merge this PR.
  • I am familiar with the contributing guidelines.

Please cherry-pick my commits into: N/A

Copy link

github-actions bot commented Jan 17, 2025

@Lennonka Lennonka force-pushed the add-invalidating-reg-tokens branch from f6abc2f to 97ccbee Compare January 17, 2025 21:56
@Lennonka Lennonka added the Waiting for code Requires merge of related code in another repository before it can be merged label Jan 17, 2025
@Lennonka

This comment was marked as outdated.

@aneta-petrova

This comment was marked as resolved.

@Lennonka Lennonka marked this pull request as ready for review January 28, 2025 14:23
@Lennonka Lennonka requested a review from girijaasoni January 28, 2025 14:25
@Lennonka Lennonka added Needs tech review Requires a review from the technical perspective Needs style review Requires a review from docs style/grammar perspective and removed Waiting for code Requires merge of related code in another repository before it can be merged labels Jan 28, 2025
@Lennonka Lennonka added tech review done No issues from the technical perspective and removed Needs tech review Requires a review from the technical perspective labels Jan 29, 2025
Copy link

@girijaasoni girijaasoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :D
Thanks @Lennonka

Copy link
Contributor

@maximiliankolb maximiliankolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made one minor comment; style-wise LGTM. I did not yet test these workflows myself though.

I like that you add WebUI, CLI, and API procedures. 👍 Lena

@maximiliankolb maximiliankolb added style review done No issues from docs style/grammar perspective and removed Needs style review Requires a review from docs style/grammar perspective labels Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
style review done No issues from docs style/grammar perspective tech review done No issues from the technical perspective
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants