-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add invalidating registration tokens #3595
base: master
Are you sure you want to change the base?
Conversation
The PR preview for eaf4c70 is available at theforeman-foreman-documentation-preview-pr-3595.surge.sh The following output files are affected by this PR: |
f6abc2f
to
97ccbee
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
guides/common/modules/proc_invalidating-jwts-of-other-users.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/proc_invalidating-jwts-of-other-users.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/proc_invalidating-jwts-of-other-users.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/proc_invalidating-jwts-of-other-users.adoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :D
Thanks @Lennonka
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made one minor comment; style-wise LGTM. I did not yet test these workflows myself though.
I like that you add WebUI, CLI, and API procedures. 👍 Lena
guides/common/modules/proc_invalidating-jwts-of-other-users.adoc
Outdated
Show resolved
Hide resolved
Co-authored-by: Maximilian Kolb <[email protected]>
What changes are you introducing?
Adding 3 procedures for invalidation of the registration JSON Web Tokens (JWTs):
All three user stories will be available in the UI, CLI, and API.
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
Redmine: 37936, 38138, 38124
RH Jira: SAT-27385 (private)
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
Checklists
Please cherry-pick my commits into: N/A