Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refer to Debian with an attribute #3660

Merged
merged 2 commits into from
Feb 13, 2025

Conversation

aneta-petrova
Copy link
Member

What changes are you introducing?

Updating references to Debian/Ubuntu so that they use an attribute.

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

Came up in #3653

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

N/A

Checklists

  • I am okay with my commits getting squashed when you merge this PR.
  • I am familiar with the contributing guidelines.

Please cherry-pick my commits into:

everywhere?

@github-actions github-actions bot added Needs tech review Requires a review from the technical perspective Needs style review Requires a review from docs style/grammar perspective Needs testing Requires functional testing labels Feb 12, 2025
@aneta-petrova aneta-petrova removed Needs tech review Requires a review from the technical perspective Needs testing Requires functional testing labels Feb 12, 2025
Copy link

github-actions bot commented Feb 12, 2025

Copy link
Contributor

@maximiliankolb maximiliankolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion. I think @evgeni would be a good person to get an ACK from (or tell me that my suggestion is wrong).

@pr-processor pr-processor bot added Waiting on contributor Requires an action from the author and removed Not yet reviewed labels Feb 12, 2025
@evgeni
Copy link
Member

evgeni commented Feb 12, 2025

Technically, we (Foreman) also do not support OpenSCAP scans for Debian clients connected to a EL Foreman. Purely by the fact that we don't offer the client bits there either.

ATIX does build SCAP client bits at https://oss.atix.de/ -- so it might work with those, idk (last time I talked to Bernhard he didn't know if anyone actually uses/tried that)?

@maximiliankolb
Copy link
Contributor

Thanks Evgeni. I also spoke with Bernhard about this: we believe that the community can use ruby-foreman-scap-client from oss.atix.de.
I am not aware of any issues reported to ATIX or via Foreman Community Forum about oss.atix.de right now.

Therefore, I propose to apply #3660 (comment) and merge this.

@evgeni
Copy link
Member

evgeni commented Feb 13, 2025

Ack, works for me!

@pr-processor pr-processor bot added Needs re-review and removed Waiting on contributor Requires an action from the author labels Feb 13, 2025
@aneta-petrova aneta-petrova added tech review done No issues from the technical perspective style review done No issues from docs style/grammar perspective and removed Needs style review Requires a review from docs style/grammar perspective labels Feb 13, 2025
@aneta-petrova aneta-petrova merged commit f2c82a9 into theforeman:master Feb 13, 2025
7 of 8 checks passed
aneta-petrova added a commit that referenced this pull request Feb 13, 2025
Co-authored-by: Maximilian Kolb <[email protected]>
(cherry picked from commit f2c82a9)
aneta-petrova added a commit that referenced this pull request Feb 13, 2025
Co-authored-by: Maximilian Kolb <[email protected]>
(cherry picked from commit f2c82a9)
aneta-petrova added a commit that referenced this pull request Feb 13, 2025
Co-authored-by: Maximilian Kolb <[email protected]>
(cherry picked from commit f2c82a9)
aneta-petrova added a commit that referenced this pull request Feb 13, 2025
Co-authored-by: Maximilian Kolb <[email protected]>
(cherry picked from commit f2c82a9)
aneta-petrova added a commit that referenced this pull request Feb 13, 2025
Co-authored-by: Maximilian Kolb <[email protected]>
(cherry picked from commit f2c82a9)
@aneta-petrova
Copy link
Member Author

Merged to "master" and cherry-picked:

62bcf69..d00ee6f 3.13 -> 3.13
7e10ce9..a736647 3.12 -> 3.12
1319e72..cd574e4 3.11 -> 3.11
cdeee6b..a41ca23 3.10 -> 3.10
8b9143c..1952cb2 3.9 -> 3.9

The attribute is missing on 3.8 and earlier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs re-review style review done No issues from docs style/grammar perspective tech review done No issues from the technical perspective
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants