Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add procedure, concept, and reference for image mode hosts #3663

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

bangelic
Copy link
Contributor

What changes are you introducing?

Combining the efforts of both PRs #3611 and #3612
New procedure, concept, and reference for image
mode hosts. Related to two Jira tickets:
https://issues.redhat.com/browse/SAT-28164 and
https://issues.redhat.com/browse/SAT-28185

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

Makes it easier to cross link modules and review.

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

Checklists

  • I am okay with my commits getting squashed when you merge this PR.
  • I am familiar with the contributing guidelines.

Please cherry-pick my commits into:

  • Foreman 3.13/Katello 4.15 (EL9 only)
  • Foreman 3.12/Katello 4.14 (Satellite 6.16)
  • Foreman 3.11/Katello 4.13 (orcharhino 6.11 on EL8 only; orcharhino 7.0 on EL8+EL9)
  • Foreman 3.10/Katello 4.12
  • Foreman 3.9/Katello 4.11 (Satellite 6.15; orcharhino 6.8/6.9/6.10)
  • Foreman 3.8/Katello 4.10
  • Foreman 3.7/Katello 4.9 (Satellite 6.14)
  • We do not accept PRs for Foreman older than 3.7.

@github-actions github-actions bot added Needs tech review Requires a review from the technical perspective Needs style review Requires a review from docs style/grammar perspective Needs testing Requires functional testing labels Feb 12, 2025
@pr-processor pr-processor bot added Waiting on contributor Requires an action from the author and removed Not yet reviewed labels Feb 13, 2025
Copy link
Contributor

@ianballou ianballou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of the changes here should be hidden for Foreman, image mode hosts are introduced by Katello.

Copy link
Contributor

@ianballou ianballou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Info still looks good from a SME standpoint.

@bangelic bangelic force-pushed the bangelic-SAT-28164-and-SAT-28185-Concept-reference-and-procedure-for-image-mode-hosts branch from f1516c7 to af6df2d Compare February 14, 2025 18:36
@pr-processor pr-processor bot added Needs re-review and removed Waiting on contributor Requires an action from the author labels Feb 14, 2025
@bangelic bangelic force-pushed the bangelic-SAT-28164-and-SAT-28185-Concept-reference-and-procedure-for-image-mode-hosts branch from af6df2d to 4894a03 Compare February 19, 2025 15:48
@Lennonka Lennonka added tech review done No issues from the technical perspective and removed Needs tech review Requires a review from the technical perspective labels Feb 25, 2025
@pr-processor pr-processor bot added the Waiting on contributor Requires an action from the author label Feb 25, 2025
@bangelic bangelic force-pushed the bangelic-SAT-28164-and-SAT-28185-Concept-reference-and-procedure-for-image-mode-hosts branch from 4894a03 to 063dbc1 Compare February 25, 2025 17:25
@pr-processor pr-processor bot removed the Waiting on contributor Requires an action from the author label Feb 25, 2025
Copy link
Contributor

@Lennonka Lennonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be the last round :)

@pr-processor pr-processor bot added Waiting on contributor Requires an action from the author and removed Needs re-review labels Feb 25, 2025
@pr-processor pr-processor bot added Needs re-review and removed Waiting on contributor Requires an action from the author labels Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs re-review Needs style review Requires a review from docs style/grammar perspective Needs testing Requires functional testing tech review done No issues from the technical perspective
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants