Update website top navigation bar #3670
Conversation
github-actions
bot
added
Needs tech review
| @@ -12,7 +12,7 @@ function buildNavigation() { | |||
|
|
|||
| return `<nav> | |||
| <a href="/"> | |||
| <img class="logo" src="/img/helmet.svg" alt="Home"> | |||
| <img class="logo" src="/img/helmet.png" alt="Home"> | |||
There was a problem hiding this comment.
A note for future me/future someone: We want svg here.
There was a problem hiding this comment.
Wouldn't it be easier to add the text as real text in here instead of adding it to the image? That way search engines can also read it. Or is it about using a specific font?
There was a problem hiding this comment.
To answer your questions:
- I intended the helmet + text as a single clickable unit. This is supposed to be a link to the home page and I want to avoid a situation where only the image part is clickable and not the text.
- I took this https://github.com/theforeman/foreman-graphics/blob/master/logo/foreman_large.png as a template and worked my way from there.
- Also, yes, it's about using a specific font.
I hope that explains my intentions but truth be told, this is one of the things that I'm hoping to get @kmalyjur's input on once she and I are able to meet again.
I appreciate your feedback, please keep it coming, this is a good place to record any concerns that we should address.
There was a problem hiding this comment.
I intended the helmet + text as a single clickable unit. This is supposed to be a link to the home page and I want to avoid a situation where only the image part is clickable and not the text.
You can do that with HTML too:
<a href="/">
<img class="logo" src="/img/helmet.svg" alt="Home">
Foreman Documentation
</a>Also, yes, it's about using a specific font.
You can load fonts into CSS and use a specific font too.
What changes are you introducing?
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
Split from and depends on #3657
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
N/A
Checklists
Please cherry-pick my commits into: