Ribbon for RC and unsupported #710
Conversation
lzap
force-pushed
the
ribbon-rc-unsupported
branch
from
74d5ede to
e666e2a
Compare
|
@ekohl the ribbon named |
guides/common/docinfo.html
Outdated
| rl.includes("/Upgrading_and_Updating/index-foreman-el.html" || | ||
| rl.includes("/Upgrading_and_Updating/index-foreman-deb.html" || | ||
| rl.includes("/Configuring_Load_Balancer/index-foreman-el.html" || | ||
| rl.includes("/Configuring_Load_Balancer/index-foreman-deb.html" { |
There was a problem hiding this comment.
This could be a regexp, but I specifically want this to be just a list so we can easily be deleting guides which are considered finished.
There was a problem hiding this comment.
I guess this is fine for now IMHO.
WIP is an abbreviation. Should we use a common English word like Draft? |
lzap
force-pushed
the
ribbon-rc-unsupported
branch
from
e666e2a to
00327f1
Compare
|
Absolutely, draft looks better. Rebased. HTML links will fail, working on that. |
lzap
force-pushed
the
ribbon-rc-unsupported
branch
from
00327f1 to
09eb8ff
Compare
|
@ekohl this is the first step in order to get closer to the ultimate goal, could you re-review please? |
|
If we could land this before 3.1 branching that would be awesome, thanks! Maybe @maximiliankolb could help since @ekohl is busy with getting the bits out. |
guides/common/docinfo.html
Outdated
| rl.includes("/Upgrading_and_Updating/index-foreman-el.html" || | ||
| rl.includes("/Upgrading_and_Updating/index-foreman-deb.html" || | ||
| rl.includes("/Configuring_Load_Balancer/index-foreman-el.html" || | ||
| rl.includes("/Configuring_Load_Balancer/index-foreman-deb.html" { |
There was a problem hiding this comment.
I guess this is fine for now IMHO.
guides/common/docinfo.html
Outdated
| @@ -1,8 +1,33 @@ | |||
| <script> | |||
| const rl = document.location.toString(); | |||
| ifdef::ribbon[] | |||
There was a problem hiding this comment.
This line was breaking JS, not sure what I meant by this. Removing.
Signed-off-by: Lukas Zapletal <[email protected]>
lzap
force-pushed
the
ribbon-rc-unsupported
branch
from
09eb8ff to
2725bf9
Compare
|
And there were ton of JS syntax errors, fixed them all now it shows up properly. Apologies for filing untested code. I also updated numbers: 3.1 and 3.0 are supported now, 3.2 will be RC, drafts are from the given list. |
This add ribon "RC" and "Unsupported" according to URL. This is hacky, but it allows us to avoid forking HTML/CSS template. Unfortunately, asciidoc syntax (and attributes) cannot be used in this header "snippet", ideally, this should have been an attribute.
Fixes #695