Remove spec2scl from add_pypi script #10304
Conversation
| @@ -48,7 +48,7 @@ generate_pypi_package() { | |||
| else | |||
| RPM_NAME_ARG="" | |||
| fi | |||
| pyp2rpm --no-autonc --sclize --no-meta-runtime-dep --no-meta-buildtime-dep -s -t $TEMPLATE -o epel7 -b $BASE_PYTHON -d $PACKAGE_DIR -v $VERSION $RPM_NAME_ARG $PYPI_NAME | |||
| pyp2rpm --no-autonc -s -t $TEMPLATE -o epel7 -b $BASE_PYTHON -d $PACKAGE_DIR -v $VERSION $RPM_NAME_ARG $PYPI_NAME | |||
There was a problem hiding this comment.
Do we still care about el7? Is there an epel8 template?
There was a problem hiding this comment.
No, we only have EL7 and Fedora atm, and that -o epel7 sets python3 as the python to be used.
There was a problem hiding this comment.
No, we only have EL7 and Fedora atm, and that
-o epel7sets python3 as the python to be used.
But -b sets the base Python to 3.
What it appears to do is blacklist it from using rich dependencies:
https://github.com/fedora-python/pyp2rpm/blob/92399daa509d2769433f97cf7f07209f738139a2/pyp2rpm/settings.py#L30
And select Python 2 & Python 3:
https://github.com/fedora-python/pyp2rpm/blob/92399daa509d2769433f97cf7f07209f738139a2/pyp2rpm/settings.py#L6
So I think you can drop it. And then you can also rely on the default value for base python.
| pyp2rpm --no-autonc -s -t $TEMPLATE -o epel7 -b $BASE_PYTHON -d $PACKAGE_DIR -v $VERSION $RPM_NAME_ARG $PYPI_NAME | |
| pyp2rpm --no-autonc -s -t $TEMPLATE -d $PACKAGE_DIR -v $VERSION $RPM_NAME_ARG $PYPI_NAME |
(which also allows you to drop line 9).
No description provided.