Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update python version requirements for ansible-collection-redhat-satellite and ansible-collection-theforeman-foreman #11745

Merged
merged 2 commits into from
Feb 19, 2025

Conversation

Odilhao
Copy link
Member

@Odilhao Odilhao commented Feb 19, 2025

No description provided.

Comment on lines 23 to 24
Requires: (python3.12-requests if (ansible-core >= 2.14.2-3 and ansible-core < 1:2.17))
Requires: (python3.12-pyyaml if (ansible-core >= 2.14.2-3 and ansible-core < 1:2.17))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, you want python3.12-* only for 1:2.16.14-3 and newer. So, how about:

Requires: (python3-requests if (ansible-core >= 1:2.14.7 and ansible-core < 1:2.16.14-3))
Requires: (python3-pyyaml if ((ansible-core >= 1:2.14.7 and ansible-core < 1:2.16.14-3))
Requires: (python3.11-requests if (ansible-core >= 2.14.2-3 and ansible-core < 1:2.14.7))
Requires: (python3.11-pyyaml if (ansible-core >= 2.14.2-3 and ansible-core < 1:2.14.7))
Requires: (python3.12-requests if ansible-core >= 1:2.16.14-3)
Requires: (python3.12-pyyaml if ansible-core >= 1:2.16.14-3)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sometimes I forget how to do packaging.

@Odilhao Odilhao force-pushed the ansible-collection-pyrequests branch from fc17de4 to f9e0cfa Compare February 19, 2025 14:36
@Odilhao Odilhao force-pushed the ansible-collection-pyrequests branch from f9e0cfa to f95b00d Compare February 19, 2025 14:37
@Odilhao Odilhao merged commit 4041a53 into theforeman:rpm/develop Feb 19, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants