-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update rubygem-hammer_cli_foreman_remote_execution to 0.3.2 #11774
Update rubygem-hammer_cli_foreman_remote_execution to 0.3.2 #11774
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
error: Installed (but unpackaged) file(s) found:
/usr/share/gems/gems/hammer_cli_foreman_remote_execution-0.3.1/.github/workflows/ci_test.yml
/usr/share/gems/gems/hammer_cli_foreman_remote_execution-0.3.1/.rubocop_todo.yml
Installed (but unpackaged) file(s) found:
/usr/share/gems/gems/hammer_cli_foreman_remote_execution-0.3.1/.github/workflows/ci_test.yml
/usr/share/gems/gems/hammer_cli_foreman_remote_execution-0.3.1/.rubocop_todo.yml
I think there are 2 solutions to this: exclude them in the spec or stop shipping them in the gem. I think the latter is cleaner, but will require a new release.
Any preference from your side?
I'll remove them from gemspec and release a new version :/ |
I wonder if this is something we'll see in more gems and we should standardize the files it includes between our plugins. |
It just happens, but mostly with older? plugins. This plugin uses UPD: It's even worse than that... We need to do some housekeeping in the repo and in the rpm spec. I'd close this PR... |
If you release a new version the bot will update this PR with the new version. No need to close it IMHO. Because of #11782 it will get rewritten, which may or may not be a good thing. |
2709bcb
to
7445bad
Compare
It did indeed 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like my rewrite script worked :)
No description provided.