Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rubygem-hammer_cli_foreman_remote_execution to 0.3.2 #11774

Merged

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Feb 23, 2025

No description provided.

@ofedoren ofedoren enabled auto-merge (rebase) February 24, 2025 11:08
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

error: Installed (but unpackaged) file(s) found:
   /usr/share/gems/gems/hammer_cli_foreman_remote_execution-0.3.1/.github/workflows/ci_test.yml
   /usr/share/gems/gems/hammer_cli_foreman_remote_execution-0.3.1/.rubocop_todo.yml
    Installed (but unpackaged) file(s) found:
   /usr/share/gems/gems/hammer_cli_foreman_remote_execution-0.3.1/.github/workflows/ci_test.yml
   /usr/share/gems/gems/hammer_cli_foreman_remote_execution-0.3.1/.rubocop_todo.yml

I think there are 2 solutions to this: exclude them in the spec or stop shipping them in the gem. I think the latter is cleaner, but will require a new release.

Any preference from your side?

@ofedoren
Copy link
Member

Any preference from your side?

I'll remove them from gemspec and release a new version :/

@ekohl
Copy link
Member

ekohl commented Feb 24, 2025

I'll remove them from gemspec and release a new version :/

I wonder if this is something we'll see in more gems and we should standardize the files it includes between our plugins.

@ofedoren
Copy link
Member

ofedoren commented Feb 24, 2025

I'll remove them from gemspec and release a new version :/

I wonder if this is something we'll see in more gems and we should standardize the files it includes between our plugins.

It just happens, but mostly with older? plugins. This plugin uses git ls-files, which I've seen only in cca 2 plugins. Other use the same logic as in hammer-cli-foreman or something similar.

UPD: It's even worse than that... We need to do some housekeeping in the repo and in the rpm spec. I'd close this PR...

@ekohl
Copy link
Member

ekohl commented Feb 25, 2025

UPD: It's even worse than that... We need to do some housekeeping in the repo and in the rpm spec. I'd close this PR...

If you release a new version the bot will update this PR with the new version. No need to close it IMHO. Because of #11782 it will get rewritten, which may or may not be a good thing.

@github-actions github-actions bot changed the title Update rubygem-hammer_cli_foreman_remote_execution to 0.3.1 Update rubygem-hammer_cli_foreman_remote_execution to 0.3.2 Feb 25, 2025
@github-actions github-actions bot force-pushed the bump_rpm/rubygem-hammer_cli_foreman_remote_execution branch from 2709bcb to 7445bad Compare February 25, 2025 12:18
@ofedoren
Copy link
Member

UPD: It's even worse than that... We need to do some housekeeping in the repo and in the rpm spec. I'd close this PR...

If you release a new version the bot will update this PR with the new version. No need to close it IMHO. Because of #11782 it will get rewritten, which may or may not be a good thing.

It did indeed 🚀

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like my rewrite script worked :)

@ofedoren ofedoren merged commit 863f1aa into rpm/develop Feb 25, 2025
3 checks passed
@ofedoren ofedoren deleted the bump_rpm/rubygem-hammer_cli_foreman_remote_execution branch February 25, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants