Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ruby-foreman-hdm v0.1.4 & smart_proxy_hdm v0.1.0 #9517

Open
wants to merge 2 commits into
base: deb/develop
Choose a base branch
from
Open

Add ruby-foreman-hdm v0.1.4 & smart_proxy_hdm v0.1.0 #9517

wants to merge 2 commits into from

Conversation

bastelfreak
Copy link
Member

No description provided.

@theforeman-bot
Copy link
Member

Can one of the admins verify this patch?

2 similar comments
@theforeman-bot
Copy link
Member

Can one of the admins verify this patch?

@theforeman-bot
Copy link
Member

Can one of the admins verify this patch?

@bastelfreak bastelfreak force-pushed the hdm_deb branch 2 times, most recently from a513a7b to 26ab37d Compare June 23, 2023 13:58
@evgeni
Copy link
Member

evgeni commented Jun 23, 2023

ok to test

evgeni
evgeni requested changes Jun 23, 2023
View reviewed changes
Copy link
Member

@evgeni evgeni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need a debian/gem.list file with contents like this:

# list of gem urls to download via Jenkins, space separated
GEMS="https://rubygems.org/downloads/foreman_hdm-0.1.4.gem"

@bastelfreak bastelfreak force-pushed the hdm_deb branch 5 times, most recently from a949e02 to 09aba9f Compare June 30, 2023 12:06
@bastelfreak bastelfreak force-pushed the hdm_deb branch 3 times, most recently from 787cb0a to b2a6709 Compare June 30, 2023 12:12
evgeni
evgeni requested changes Jun 30, 2023
View reviewed changes
Copy link
Member

@evgeni evgeni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a debian/install with the following contents pls:

foreman_hdm.rb           usr/share/foreman/bundler.d
cache                        usr/share/foreman/vendor
webpack/foreman_hdm      var/lib/foreman/public/webpack
assets                       var/lib/foreman/public

@bastelfreak bastelfreak changed the title Add ruby-foreman-hdm v0.1.4 Add ruby-foreman-hdm v0.1.4 & smart_proxy_hdm v0.1.0 Jun 30, 2023
@bastelfreak bastelfreak force-pushed the hdm_deb branch 2 times, most recently from 55a0d86 to d583a5c Compare June 30, 2023 13:33
evgeni
evgeni requested changes Jul 4, 2023
View reviewed changes
evgeni
evgeni reviewed Jul 9, 2023
View reviewed changes
plugins/smart_proxy_hdm/install
@@ -0,0 +1,3 @@
debian/hdm.rb usr/share/foreman-proxy/bundler.d
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
debian/hdm.rb usr/share/foreman-proxy/bundler.d

evgeni
evgeni reviewed Jul 9, 2023
View reviewed changes
plugins/ruby-foreman-hdm/debian/foreman_hdm.rb
@@ -0,0 +1 @@
gem 'foreman_hdm', '0.1.4'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file is unused (you have a foreman_hdm.rb outside the debian folder too)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evgeni evgeni evgeni requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
DEB Needs re-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bastelfreak @theforeman-bot @evgeni