Fixes #38037 - Update last login time for External Auth user #10443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofedoren
reviewed
Feb 14, 2025
There was a problem hiding this comment.
Thanks, @adamruzicka! Just to be sure: as a side effect this will also assign Default role to the user, do we want that?
|
I took over #10387 , rebased it and now I'm making the tests happy.
I think so, yes. |
ofedoren
reviewed
Feb 14, 2025
There was a problem hiding this comment.
Thanks, @adamruzicka ! LGTM. Foreman tests are happy, Katello ones should not be related.
Could you please squash the commits?
adamruzicka
force-pushed
the
last-login
branch
from
7609ce4 to
1f49280
Compare
|
I keep forgetting we don't have squash on merge here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.