Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #38217 - Set autocomplete attribute on name inputs #10444

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

adamruzicka
Copy link
Contributor

to prevent a password manager from suggesting saved credentials in various name fields.

to prevent a password manager from suggesting saved credentials in
various name fields.
@adamruzicka
Copy link
Contributor Author

The issue also mentioned these

  1. Infrastructure -> Virt-who Configurations
  2. Infrastructure -> HTTP Proxies
  3. Administer -> Authentication Sources
  4. Administer -> Users -> Create User -> User -> Email Address

Even with this patch, the password manager still offers suggestions for hypervisor username & password in 1, username & password in 2, account username & password in 3. Considering all of these are actual credentials, I'd let the password manager do its thing.

Administer -> Users -> Create User -> User -> Email Address

This remains. Sadly some browsers (at least firefox) seem to completely ignore autocomplete="off" so we'd have to resort to hacks to make it go away.

Copy link
Member

@MariaAga MariaAga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code makes sense and tested on the hostgroup form, thanks!

@MariaAga MariaAga merged commit 24e492b into theforeman:develop Feb 17, 2025
28 of 31 checks passed
@adamruzicka adamruzicka deleted the autocomplete branch February 17, 2025 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants