Fixes #38232 - Fix GRUB2 loader commands for Debian/Ubuntu #10455
+8
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Supersedes #10430 |
ekohl
requested changes
Feb 21, 2025
| efi_suffix = 'efi' | ||
| os_major = @host.operatingsystem.major.to_i | ||
|
|
||
| if (os_major > 12 && os_major < 24) |
There was a problem hiding this comment.
Please include an OS name check like in the other file because this will be incorrect for Debian 13.
There was a problem hiding this comment.
Autoinstall is Ubuntu only, Debian is using preseed.
There was a problem hiding this comment.
Ah right, so you're referring to Ubuntu 12.04. That makes a lot more sense.
ekohl
approved these changes
Feb 24, 2025
|
Cannot merge due to failed CI jobs. @jloeser can you please fix the commit message & rebase over the latest develop? If it will be green, I'll merge it. |
Back in time, GRUB2 is using `linux` and `initrd` loader commands to load the kernel and initrd into ram on legacy BIOS. Later, `linuxefi` and `initrdefi` loader commands have been added to do the same on UEFI platforms as some kind of interim solution. These out-of-tree patches have been added by the vendors. First vendors [1] started now to drop patches for `linuxefi`/`initrdefi` loader commands support, `linux`/`initrd` of course also work under UEFI then. Thus, we need to adapt preseed templates to render correct templates with supported loader commands. [1]:https://salsa.debian.org/grub-team/grub/-/commit/5cf01c9d98bda554ac2460a6e68e34743a19328f
jloeser
force-pushed
the
38232-fix-grub-loader-commands
branch
from
1b74a44 to
1b8bca4
Compare
jloeser
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back in time, GRUB2 is using
linuxandinitrdloader commands to load the kernel and initrd into ram on legacy BIOS. Later,linuxefiandinitrdefiloader commands have been added to do the same on UEFI platforms as some kind of interim solution. These out-of-tree patches have been added by the vendors.First vendors 1 started now to drop patches for
linuxefi/initrdefiloader commands support,linux/initrdof course also work under UEFI then.Thus, we need to adapt preseed templates to render correct templates with supported loader commands.