Fixes #38242 replace clipboard copy with pf5 #10457
Open
+35
−82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lukshio
changed the title
MariaAga
requested changes
Feb 27, 2025
| <% if @host.operatingsystem && @host.initial_configuration_template %> | ||
| <div style="max-width: 600px"> | ||
| <%= _('For initial configuration of the host run this command:') %> | ||
| <%= react_component('ClipboardCopy', { text: "curl #{@host.registration_url} | bash", | ||
| textareaProps: { readOnly: true, rows: '1', className: 'host-init-conf-textarea'}}) | ||
| <%= react_component('ClipboardCopy', { text: "curl #{@host.registration_url} | bash" , textareaProps: {className: 'host-init-conf-textarea'}}) |
| @@ -20,3 +20,11 @@ | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| .pf-c-clipboard-copy.pf-m-inline{ | |||
There was a problem hiding this comment.
Please add a classname to the PF component and use it for the css to prevent this css effecting other clipboardCopies
There was a problem hiding this comment.
Or, remove the css and change the variant from inline to a normal type, that also looks fine to me. otherwise, we use pf variables for numbers and colors: https://v5-archive.patternfly.org/developer-resources/global-css-variables
| variant={PFClipboardCopyVariant.expansion} | ||
| isExpanded | ||
| isReadOnly={textareaProps.readOnly ?? false} | ||
| className={textareaProps.className ?? ''} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.