Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #38252 - Handle boolean searchable_value displayed as true/false in search field #10462

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
+6 −0
Draft

Fixes #38252 - Handle boolean searchable_value displayed as true/false in search field #10462

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions app/models/concerns/hostext/search.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,12 @@ def search_by_hostgroup_and_descendants(key, operator, value)

def search_by_params(key, operator, value)
key_name = key.sub(/^.*\./, '')

if Parameter.find_by(name: key_name)&.key_type == 'boolean'
# boolean value is saved as 't'/'f' in searchable_value column
value = value.chr
end

condition = sanitize_sql_for_conditions(["name = ? and searchable_value #{operator} ?", key_name, value_to_sql(operator, value)])
p = Parameter.where(condition).reorder(:priority)
return {:conditions => '1 = 0'} if p.blank?
Expand Down
Loading