Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloud-init user data: replace deprecated lock-passwd with lock_passwd #9974

Closed
wants to merge 1 commit into from

Conversation

kenyon
Copy link
Contributor

@kenyon kenyon commented Jan 2, 2024

https://cloudinit.readthedocs.io/en/latest/reference/modules.html#users-and-groups says that lock-passwd was deprecated in cloud-init version 22.3, use lock_passwd instead.

@theforeman-bot
Copy link
Member

Can one of the admins verify this patch?

2 similar comments
@theforeman-bot
Copy link
Member

Can one of the admins verify this patch?

@theforeman-bot
Copy link
Member

Can one of the admins verify this patch?

@kenyon kenyon changed the title cloud-init user data: replace deprecated lock-passwd with lock_passwd cloud-init user data: replace deprecated lock-passwd with lock_passwd Jan 2, 2024
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://cloudinit.readthedocs.io/en/latest/reference/modules.html#users-and-groups says that lock-passwd was deprecated in cloud-init version 22.3, use lock_passwd instead.

EL7, Debian Buster (10) and Bullseye (11) still have < 22.3, so those would be broken.

Debian Bookworm (12), Ubuntu Focal (20.04) and El8 all have version > 22.3.

I'm unsure how to deal with this. If it's only deprecated and not broken, I'd lean to keeping the old version for a while. The alternative is to use parameters or version checks, but I generally prefer to avoid complexity.

@kenyon
Copy link
Contributor Author

kenyon commented Jan 3, 2024

Yeah I didn't check for OS support. Feel free to close, or leave open as a reminder to do eventually, or however this project tracks changes that eventually need to happen.

@kenyon
Copy link
Contributor Author

kenyon commented Mar 26, 2024

#10048 did this.

@kenyon kenyon closed this Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants