Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #37025 - Navigation should only have 1 item expanded #9978

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Fixes #37025 - Navigation should only have 1 item expanded #9978

merged 1 commit into from
Jan 4, 2024

Conversation

MariaAga
Copy link
Member

@MariaAga MariaAga commented Jan 4, 2024

When a user expends an item, and then expends another item the first expended item will collapse.

@github-actions github-actions bot added the UI label Jan 4, 2024
@MariaAga
Copy link
Member Author

MariaAga commented Jan 4, 2024

test failure fixed here: #9979

kmalyjur
kmalyjur approved these changes Jan 4, 2024
View reviewed changes
Copy link
Contributor

@kmalyjur kmalyjur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for your explanatory comments

@MariaAga
Copy link
Member Author

MariaAga commented Jan 4, 2024 •
edited
Loading

Thank you! Rebased to fix tests.

ofedoren
ofedoren approved these changes Jan 4, 2024
View reviewed changes
Copy link
Member

@ofedoren ofedoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @MariaAga, LGTM and seems to fix the issue :)

@ofedoren ofedoren merged commit bf39cd0 into theforeman:develop Jan 4, 2024
20 checks passed
@ekohl
Copy link
Member

ekohl commented Jan 4, 2024

expended

Typo: expanded?

@MariaAga
Copy link
Member Author

MariaAga commented Jan 4, 2024

TIL: expend means to spend, while expand means to increase in size.
so expend is a typo, but in the code its correct

@MariaAga MariaAga changed the title Fixes #37025 - Navigation should only have 1 item expended Fixes #37025 - Navigation should only have 1 item expanded Jan 4, 2024
@ofedoren
Copy link
Member

ofedoren commented Jan 4, 2024

TIL: I need glasses :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofedoren ofedoren ofedoren approved these changes

@kmalyjur kmalyjur kmalyjur approved these changes

Assignees
No one assigned
Labels
UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MariaAga @ekohl @ofedoren @kmalyjur