-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i18n - pulling from tx #182
Conversation
This file is automatically generated and doesn't need to be tracked.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lfu Since you are doing the release of virt-who-configure, are you able to review this one? Once it's out of Draft state.
f9a687b
to
c0850ec
Compare
I'm not sure if .mo files should be tracked in the repo. Looks like Foreman and Katello are not tracking .mo files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ekohl
That's a good question and you're right: ideally we shouldn't keep them in git because they're the compiled For Foreman we compile it in packaging: For Katello the release process is a bit special and they're built locally so they're included in the I started an approach that essentially does the same as Foreman for Katello: theforeman/foreman-packaging#10035 Once that works, we should be able to apply the same approach to all plugins and remove the files from git, add them to Until then we take the ugly approach. |
No description provided.