Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use the right username when computing the db password hash #373

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Conversation

evgeni
Copy link
Member

@evgeni evgeni commented Jan 28, 2025

some people use other names than pulp for their DB user

some people use other names than `pulp` for their DB user

Fixes: d469252
Copy link
Collaborator

@wbclark wbclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, how did this come up?

Probably no point to add Refs #28901 now given how old that feature is. Is there some newer associated Redmine?

@ekohl ekohl added the Bug Something isn't working label Jan 28, 2025
@evgeni
Copy link
Member Author

evgeni commented Jan 28, 2025

Interesting, how did this come up?

user had external db deployed with pulpcore as the username, now they are moving back to internal and when setting manage=true they ended up with not being able to talk to the db anymore.

@evgeni evgeni merged commit 048dd11 into master Jan 28, 2025
17 checks passed
@evgeni evgeni deleted the dbuser branch January 28, 2025 16:49
@evgeni
Copy link
Member Author

evgeni commented Feb 19, 2025

Oh, and to add a pinch of mystery to this: You need to use MD5-auth (so Foreman 3.10 or older) to actually run into a problem here.
With SCRAM the code here would still use the "wrong" salt, but that salt is properly stored in PostgreSQL (and can actually be anything!) and thus authentication works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants