-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add StarfallError hook and rework processor error reporting #1584
Conversation
I finished cleaning it up if you want to verify it |
I also clamped the strings to 1024 length |
@thegrb93 I got fixes for all of those, want me to push them? |
Well, Imma push them, you can revert stuff you don't like or request changes. |
Yah, push pls |
Yeah I did, for some reason GitHub displayed the commits way above all the review comments. |
Looks good. I can test it out soon |
…#1584) * Rework error reporting and add 'StarfallError' hook --------- Co-authored-by: Garrett Brown <[email protected]>
Continuing the discussion from #1582 (comment): How about this?
The hook runs on both realms and is relayed to ALL PLAYERS. This is something you didn't want, but I thought it could be useful in the future or maybe for other addons. I can change it if you really really want tho :(
Parameters in the global
StarfallError
hook are:nil
if the error originated on the serversideRegarding the notifications, in addition to checking if
sf_timebuffer_cl
is greater than0
, now it also checks whether the user has blocked your Starfalls. It's super annoying to constantly receive these notifications from people you might've allegedly minged in the past :)I need clarification on 2 things though:
Starfall 'main' owned by Name has errored: SF:main:6: some error message
logged to the console, but no traceback unlike previously. Is that OK? Keep in mind that owner of the chip will still get the full traceback printed for that client so they can debug the script.