Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notification.addCaption #1977

Closed
wants to merge 1 commit into from
Closed

Add notification.addCaption #1977

wants to merge 1 commit into from

Conversation

thegrb93
Copy link
Owner

Fixes: #1898

@thegrb93
Copy link
Owner Author

Need to make sure spamming it doesn't crash the game

@adamnejm
Copy link
Collaborator

adamnejm commented Jan 16, 2025

Need to make sure spamming it doesn't crash the game

Everything is fine on my end, can lag a little bit, but that's fine with the permissions.
Special characters do not cause any issues either.

The problem is with special captions, take this for example:

for i = 1, 60 do
    notification.addCaption("<delay:"..i..">Ughhh", 1)
end

The captions will continuously show up, even if the chip is removed. This could be abused.

The <len> arg can be fucked around with too.

@adamnejm
Copy link
Collaborator

adamnejm commented Jan 16, 2025

Although take "abuse" lightly here, at most I think it would force the user to reconnect to the server to make the captions disappear or set closedcaptions to 0.

@adamnejm
Copy link
Collaborator

Would be nice if there was a command to clear the closed captions, but I tested all the cc_* commands and none of them do that.

@thegrb93
Copy link
Owner Author

I didn't realize there were embedded commands. Probably don't want this then, and it's not that hard to render your own.

@thegrb93 thegrb93 closed this Jan 17, 2025
@thegrb93 thegrb93 deleted the caption branch January 17, 2025 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose gui.AddCaption
2 participants