Add getModelRenderBounds, getCollisionBounds, getRotatedAABB #2010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thegrb93
requested changes
Feb 24, 2025
lua/starfall/libs_sh/entities.lua
Outdated
| -- @return Vector Minimum extent of the AABB relative to entity's position. | ||
| -- @return Vector Maximum extent of the AABB relative to entity's position. | ||
| function ents_methods:getRotatedAABB(min, max) | ||
| local minvec, maxvec = Ent_GetRotatedAABB(getent(self), vunwrap1(min), vunwrap1(max)) |
There was a problem hiding this comment.
The second vunwrap1 needs to be vunwrap2, otherwise they both write to the same cached vector.
There was a problem hiding this comment.
Don't forget to add to line 70,73 as well
thegrb93
approved these changes
Feb 27, 2025
github-actions bot
added a commit
that referenced
this pull request
Feb 27, 2025
* Add getModelRenderBounds, getCollisionBounds, getRotatedAABB * Fix --------- Co-authored-by: thegrb93 <[email protected]> 8438052
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
Entity:getModelRenderBounds,Entity:getCollisionBounds, andEntity:getRotatedAABB(shared) functions.(untested)