Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement entity:setTriggerListener #2012

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

katsu6436
Copy link
Contributor

chat theres nothing unsanitized here right

Before creating pull request

  • Move all changes to separate branch (Don't use master of your fork).
  • Don't reuse branches.
  • Don't sync that branch after creating pull request unless it's really needed. (IE. upstream changed code structure).
  • Test it and try fixing bugs ahead.
  • If you know about any bugs, make sure to list them in PR message.
  • Make sure pull request message informs about ALL the changes.
  • Your pull request can be work-in-progress if you want others to help you with coding or give you opinions, just make sure to state it's not ready.
  • Try to avoid messing with whitespaces. (Setup your editor properly to follow our style).
  • If you find whitespaces that don't follow our style you can fix them in separate commit.
  • Read about github flow

Thank you

Thank you for contributing and helping StarfallEx community!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant